Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special handling for Twitch bits emotes #2745

Closed
Mm2PL opened this issue May 4, 2021 · 7 comments · Fixed by #3136
Closed

Add special handling for Twitch bits emotes #2745

Mm2PL opened this issue May 4, 2021 · 7 comments · Fixed by #3136
Assignees

Comments

@Mm2PL
Copy link
Collaborator

Mm2PL commented May 4, 2021

Enhancement

What should be added?

I would like to have Twitch bits emotes (emotes v2) to have special handling when it comes to twitchemotes.com links and possibly a label.

  • The menu item for opening the emote info should not appear because emotes v2 cannot be indexed (thanks Twitch)
  • Potentially updating the Twitch emote label to include that it's a bits emote.

Why should it be added?

Non-existent twitchemotes.com links suck.

@Mm2PL Mm2PL added the issue-report An issue reported by a user. label May 4, 2021
@zneix zneix self-assigned this May 5, 2021
@zneix
Copy link
Collaborator

zneix commented May 5, 2021

Totally agree with you 👍 I'll look into this over the weekend!

@Mm2PL
Copy link
Collaborator Author

Mm2PL commented Jun 18, 2021

Apparently new emotes can get emotesv2 links even if they are not bit emotes. :(

@pajlada pajlada removed the issue-report An issue reported by a user. label Jun 20, 2021
@pajlada
Copy link
Member

pajlada commented Jun 20, 2021

We will not further any functionality related to twitchemotes.com

@pajlada pajlada closed this as completed Jun 20, 2021
@zneix
Copy link
Collaborator

zneix commented Jun 20, 2021

From what I saw yesterday twitchemotes.com still provides information about emotes and it seems like they provide information about user's bit emotes too - only URL has changed, see https://twitchemotes.com/channels/99631238 for example and notice how emote links look like now.

Might be worth exploring if we can somehow access the id of the emote owner account and build a URL to emote page on twitchemotes.

@pajlada
Copy link
Member

pajlada commented Jun 20, 2021

To clarify, we shouldn't spend any time working on functionality for a website that isn't yet in a stable phase. We can revisit once they have things actually working, and not in this inbetween zombie state.

@zneix
Copy link
Collaborator

zneix commented Jun 20, 2021

To clarify, we shouldn't spend any time working on functionality for a website that isn't yet in a stable phase. We can revisit once they have things actually working, and not in this inbetween zombie state.

Understood. Given your input, should we now remove entry from the context menu that appears upon right-clicking Twitch emotes to open TwirchEmotes page since it's broken?

@pajlada
Copy link
Member

pajlada commented Jun 20, 2021

To clarify, we shouldn't spend any time working on functionality for a website that isn't yet in a stable phase. We can revisit once they have things actually working, and not in this inbetween zombie state.

Understood. Given your input, should we now remove entry from the context menu that appears upon right-clicking Twitch emotes to open TwirchEmotes page since it's broken?

If you want to take the time to do it that's fine by me - yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants