Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitchemotes link in emote context menu not working anymore #3114

Closed
LosFarmosCTL opened this issue Aug 3, 2021 · 6 comments · Fixed by #3136
Closed

Twitchemotes link in emote context menu not working anymore #3114

LosFarmosCTL opened this issue Aug 3, 2021 · 6 comments · Fixed by #3136
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user

Comments

@LosFarmosCTL
Copy link
Contributor

Describe your issue

The context menu currently appearing when secondary/right clicking on an emote in chat is still using the twitchemotes.com link for subemotes, but due to that site being basically useless now, and the link structure being changed none of the links actually work anymore.
I do not know if there is any discussion internally or something about what to replace it with, but right now the functionality is completely broken.

OS and Chatterino Version

macOS Big Sur, Chatterino 2.3.3

@LosFarmosCTL LosFarmosCTL added the issue-report An issue reported by a user. label Aug 3, 2021
@ALazyMeme
Copy link
Collaborator

To clarify: the 1x, 2x and 3x buttons still work. Just the TwitchEmotes links don't work.

@ALazyMeme ALazyMeme added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user and removed issue-report An issue reported by a user. labels Aug 4, 2021
@ALazyMeme
Copy link
Collaborator

It's possible that twitchemotes have removed v1 fetching altogether. Which would make sense, since a lot of forsen's basic emotes aren't on their website:
image

The link format has also changed
Current Chatterino Implementation: https://twitchemotes.com/emotes/emotesv2_93c0aa2b0d1f4ab0825a3c83ece9b200
TwitchEmotes: https://twitchemotes.com/channels/22484632/emotes/emotesv2_93c0aa2b0d1f4ab0825a3c83ece9b200

@LosFarmosCTL
Copy link
Contributor Author

LosFarmosCTL commented Aug 5, 2021

It's possible that twitchemotes have removed v1 fetching altogether. Which would make sense, since a lot of forsen's basic emotes aren't on their website

I am honestly right now completely lost on just how exactly their website is broken.
I.e. for forsen there are only all basic emotes missing right now, while for basically all other channels its just the animated ones that are not there.

I feel like twitchemotes just might not be a reliable source anymore going forward, at least for my personal use, i.e. supibot aliases or bot commands, I have completely replaced it for my personal use, i.e. supibot aliases or bot commands, with cbdg's emotes.raccatta.cc but idk if that's a reliable enough source going into the future.

If there was some service the devs could agree upon I could take a look into implementing it.

@ALazyMeme
Copy link
Collaborator

cbdg's website looks nice, but there's no individual pages for emotes

What if we just removed the twitchemotes link altogether and just left the 3 sized options?

@LosFarmosCTL
Copy link
Contributor Author

What if we just removed the twitchemotes link altogether and just left the 3 sized options?

Personally i wouldn't have a problem with that, i mostly use bots to look up emotes anyways, i can't remember the last time i used the chatterino menu for it.

Not sure if other people do use it though, but right now i don't really know a good site chatterino could link to.

@zneix
Copy link
Collaborator

zneix commented Aug 7, 2021

See #2745 (comment)

I'd remove it already but I was just too lazy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants