Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block List capped at 100 users #2767

Closed
LeetHaxor opened this issue May 11, 2021 · 11 comments · Fixed by #4721
Closed

Block List capped at 100 users #2767

LeetHaxor opened this issue May 11, 2021 · 11 comments · Fixed by #4721

Comments

@LeetHaxor
Copy link

Added a bunch of spammers to my block list, but when I go to the block list there's only 20 users listed. If I add more than 20 it shows blank lines as if they were added (but no text on the line), but when I reload chatterino it's capped at 20. They are still ignored on normal twitch chat, but I can see their messages in chatterino (and yes I am using "Enable twitch blocked users"). Is there some limitation in place that prevents more than 20 blocks?

@LeetHaxor LeetHaxor added the issue-report An issue reported by a user. label May 11, 2021
@Mm2PL
Copy link
Collaborator

Mm2PL commented May 11, 2021

Chatterino version?

@LeetHaxor
Copy link
Author

Chatterino Nightly 2.3.1 (commit 2ea233a, )

@ALazyMeme
Copy link
Collaborator

ALazyMeme commented May 11, 2021

Yes, we don't move past the first "page" for blocked users. No idea why

@LeetHaxor
Copy link
Author

Yes, we don't move past the first "page" for blocked users. No idea why

That's unfortunate. I suppose there's not much I can do then. Thanks.

@Mm2PL
Copy link
Collaborator

Mm2PL commented May 11, 2021

While the question you asked got an answer, I'd still consider this an issue and something that could be fixed.

@LeetHaxor
Copy link
Author

LeetHaxor commented May 11, 2021

While the question you asked got an answer, I'd still consider this an issue and something that could be fixed.

Oh okay, reopening for now then!

@LeetHaxor LeetHaxor reopened this May 11, 2021
@fourtf
Copy link
Member

fourtf commented May 11, 2021

Needs to be capped at some level so it doesn't spam too many requests if the user has millions of blocks (maybe ~10000 blocks?).

@LeetHaxor
Copy link
Author

Needs to be capped at some level so it doesn't spam too many requests if the user has millions of blocks (maybe ~10000 blocks?).

Makes sense. Currently at 250+, so hopefully something above that is easily achievable. Thanks.

@zneix
Copy link
Collaborator

zneix commented May 15, 2021

A little update on this: on latest nightly block list returns 100 blocks, we'll soon make a fix to respect pagination returned from Twitch's API and try to return all users in the block list.

@zneix zneix changed the title Block List capped at 20 users Block List capped at 100 users May 15, 2021
@Felanbird Felanbird added enhancement and removed issue-report An issue reported by a user. labels Nov 27, 2021
@occluder
Copy link

Needs to be capped at some level so it doesn't spam too many requests if the user has millions of blocks (maybe ~10000 blocks?).

May I propose adding a setting for users to choose how many blocked users they want to load? Sounds like a good compromise

@pajlada
Copy link
Member

pajlada commented Mar 21, 2023

Needs to be capped at some level so it doesn't spam too many requests if the user has millions of blocks (maybe ~10000 blocks?).

May I propose adding a setting for users to choose how many blocked users they want to load? Sounds like a good compromise

I would rather just increase the amount and cap it somewhere higher. Maybe 1000 (so 10 requests)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants