Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocked users' redemptions are visible in chat #3098

Closed
Supinic opened this issue Jul 31, 2021 · 1 comment · Fixed by #3102
Closed

Blocked users' redemptions are visible in chat #3098

Supinic opened this issue Jul 31, 2021 · 1 comment · Fixed by #3102
Labels
issue-report An issue reported by a user.

Comments

@Supinic
Copy link

Supinic commented Jul 31, 2021

If a user is blocked (via Twitch) and uses a redemption without text, the redemption is still visible in chat. For reference, twitch web chat has these redemptions hidden.

This only applies to redemptions without text - if I recall correctly, those are not sent via IRC, unlike those with text. As far as I'm concerned, this behavior is up to clients to implement as the redemptions are sent regardless of blocks.

@Supinic Supinic added the issue-report An issue reported by a user. label Jul 31, 2021
@iProdigy
Copy link
Contributor

iProdigy commented Aug 1, 2021

This is related to #2767 - fixing this would require paginating through the full list of blocks to determine the user_ids whos redemptions should not be shown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue-report An issue reported by a user.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants