Check for ignored phrases/users in channel point redemptions #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zneix
requested changes
Aug 1, 2021
zneix
approved these changes
Aug 1, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Aug 3, 2021
Now we're on commit 95044ef; Changes from upstream we pulled: - Minor: Now uses spaces instead of magic Unicode character for sending duplicate messages (Chatterino#3081) - Minor: Added `channel.live` filter variable (Chatterino#3092, Chatterino#3110) - Bugfix: Channel point redemptions from ignored users are now properly blocked. (Chatterino#3102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Dev note:
Because a channel point message is contextless (i.e. has no channel attached), we have to attach the relevant parameters to the function call itself. The alternative to this would be to make the function non-static, but we'd have to rework TwitchMessageBuilder and SharedMessageBuilder to work with a null ircmessage which is not something I want to do.
Fixes #3098