Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emote/user tab completion completes using wrong word #3101

Closed
jupjohn opened this issue Aug 1, 2021 · 3 comments · Fixed by #4735
Closed

Emote/user tab completion completes using wrong word #3101

jupjohn opened this issue Aug 1, 2021 · 3 comments · Fixed by #4735
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user

Comments

@jupjohn
Copy link
Contributor

jupjohn commented Aug 1, 2021 •
edited
Loading

Describe your issue
Tab completion of emotes/usernames can also complete when moving to prior word.

Steps to reproduce

  1. Type a single word
  2. Type another word and tab complete to an emote/user
  3. Press left arrow until you are at the last character of the first word
  4. Press tab again

Expected behaviour
Previous word tries to complete using the word

Observed behaviour
Previous word thinks it's the second word so tried to complete using those characters

Screenshots
https://user-images.githubusercontent.com/4962764/127768320-e14afc52-4b84-4ff3-ab03-c604c6f248e0.mp4

OS and Chatterino Version
Arch Linux (N/A), Chatterino 2.3.3 (commit ae9f92d)

This is a hard one to explain (and title), hope the vid does it justice.
@jupjohn jupjohn added the issue-report An issue reported by a user. label Aug 1, 2021
@Mm2PL Mm2PL added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user and removed issue-report An issue reported by a user. labels Aug 1, 2021
@Mm2PL
Copy link
Collaborator

Mm2PL commented Aug 1, 2021

Can reproduce on ae9f92d

@xHeaveny
Copy link
Contributor

xHeaveny commented Aug 1, 2021 •
edited by zneix
Loading

can also reproduce on 3cb1e51

@M4tthewDE
Copy link
Contributor

I did some investigation and it looks like the completer doesn't respect changing the cursor.
This happens as well if the cursor is changed with the mouse or the entire content of the textbox with up-arrow/down-arrow.
This issue could probably be solved by adding a check inside of ResizingTextEdit::keyPressEvent for those specific events.

@Mm2PL Mm2PL mentioned this issue Jul 27, 2023
Closed
4 tasks
@Mm2PL Mm2PL self-assigned this Jul 27, 2023
Mm2PL added a commit that referenced this issue Jul 27, 2023
@Mm2PL
Fixed tab completion rarely completing the wrong word.
a0ebdf7 
Fixes: #3101
@Mm2PL Mm2PL mentioned this issue Jul 27, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 31, 2023
@Mm2PL
Fixed tab completion rarely completing the wrong word. (#4735)
89323ff 
* Fixed tab completion rarely completing the wrong word.

Fixes: #3101

* Use QSignalBlocker instead of janky bool, add comment about hidden logic

* copypasteo
@Mm2PL Mm2PL removed their assignment Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed tab completion rarely completing the wrong word. Chatterino/chatterino2
4 participants
@jupjohn @Mm2PL @M4tthewDE @xHeaveny