Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+F Not Searching Extended Message History #4495

Closed
4 tasks done
RyanPotat opened this issue Mar 31, 2023 · 1 comment · Fixed by #4496
Closed
4 tasks done

Ctrl+F Not Searching Extended Message History #4495

RyanPotat opened this issue Mar 31, 2023 · 1 comment · Fixed by #4496
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Feature: Search Issues related to the CTRL+F Search function

Comments

@RyanPotat
Copy link

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

After increasing 'Split message scrollback limit', Ctrl+F or Ctrl+Shift+F will not search the extended history, and only search through the standard 1k messages.

Screenshots

image

OS and Chatterino Version

Technorino Nightly 7.4.2 (commit 00f00e2) built on 2023-03-24 with Qt 5.15.2, Windows SDK, MSVC 193431942, Crashpad Running on Windows 10 Version 2009, kernel: 10.0.19044
@RyanPotat RyanPotat added the issue-report An issue reported by a user. label Mar 31, 2023
@Felanbird Felanbird added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Feature: Search Issues related to the CTRL+F Search function and removed issue-report An issue reported by a user. labels Mar 31, 2023
@Felanbird
Copy link
Collaborator

Felanbird commented Mar 31, 2023 •
edited
Loading

While this isn't the first time I've heard about this, I'm wondering when it broke.

I'm fairly sure it was confirmed to work in the PR adding this functionality, as I know I wanted to make sure searching an insane amount of messages would not cause any stability issues.

@kornes kornes mentioned this issue Mar 31, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Feature: Search Issues related to the CTRL+F Search function
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix channel search when custom scrollback limit is used kornes/chatterino2
2 participants
@Felanbird @RyanPotat