Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brave browser to IncognitoBrowser.cpp so that links open in a private tab #5451

Closed
4 tasks done
nrpHD opened this issue Jun 12, 2024 · 0 comments · Fixed by #5452
Closed
4 tasks done

Add Brave browser to IncognitoBrowser.cpp so that links open in a private tab #5451

nrpHD opened this issue Jun 12, 2024 · 0 comments · Fixed by #5452
Labels
issue-report An issue reported by a user.

Comments

@nrpHD
Copy link

nrpHD commented Jun 12, 2024

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

When setting the Brave browser as your default browser, clicking a link will open it in non-incognito mode.

It should behave the same as on e.g. Firefox, where the link is opened in a private tab.
It should only open in non-incognito mode via right click -> open link.

My assumption is that this can be achieved by adding Brave to the list of browser in the IncognitoBrowser.cpp file.

Screenshots

image

OS and Chatterino Version

Chatterino 2.5.1 (commit eafcb94) built with Qt 6.5.0, Running on Windows 11 Version 23H2, kernel: 10.0.22631

@nrpHD nrpHD added the issue-report An issue reported by a user. label Jun 12, 2024
Niller2005 added a commit to Niller2005/chatterino2 that referenced this issue Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue-report An issue reported by a user.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant