change default local r9k keybinding per macOS standard #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
reviewed
Dec 10, 2024
| @@ -516,7 +516,7 @@ void HotkeyController::addDefaults(std::set<QString> &addedHotkeys) | |||
| std::vector<QString>(), "reopen split"); | |||
|
|
|||
| this->tryAddDefault(addedHotkeys, HotkeyCategory::Window, | |||
| QKeySequence("Ctrl+H"), "toggleLocalR9K", | |||
| QKeySequence("Ctrl+."), "toggleLocalR9K", | |||
There was a problem hiding this comment.
This should be #ifdef Q_OS_MACOSd.
Mm2PL
requested changes
Dec 10, 2024
Comment on lines
518
to
520
| this->tryAddDefault(addedHotkeys, HotkeyCategory::Window, | ||
| QKeySequence("Ctrl+H"), "toggleLocalR9K", | ||
| QKeySequence("Ctrl+."), "toggleLocalR9K", | ||
| std::vector<QString>(), "toggle local r9k"); |
There was a problem hiding this comment.
This does not change configs for existing users. This is probably not what should be done here as CMD+H is already reserved there is no harm forcing toggle local r9k to be rebound to it for every user.
This doesn't change anything on Windows or Linux, so it's fine. I don't know about common macOS key binds, so I can't comment on the chosen bind. |
|
I didn’t think a tremendous amount about the keymap, just settled on something that works and is easily pressable. The only other option I considered is `Cmd` + `,`, but this is already reserved to open the settings interface. I figured if something more mnemonic is considered in the future, this can always be changed again
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5711
#5711 is labelled as a bug, but this behavior is intended (source) (source)
easiest fix is to change the default local r9k keymap. while
Ctrl/Cmd+His a more mnemonic keymap, I do not think it is mnemonic enough to be worth making all macOS users have to configure this setting manually.