Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default local r9k keybinding per macOS standard #5764

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

change default local r9k keybinding per macOS standard #5764

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
161b312
change default local r9k keybinding per macOS standard
jacob-thompson Dec 10, 2024
135d972
change default local r9k keymap specifically for macOS
jacob-thompson Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/controllers/hotkeys/HotkeyController.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ void HotkeyController::addDefaults(std::set<QString> &addedHotkeys)
std::vector<QString>(), "reopen split");

this->tryAddDefault(addedHotkeys, HotkeyCategory::Window,
QKeySequence("Ctrl+H"), "toggleLocalR9K",
QKeySequence("Ctrl+."), "toggleLocalR9K",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be #ifdef Q_OS_MACOSd.

std::vector<QString>(), "toggle local r9k");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not change configs for existing users. This is probably not what should be done here as CMD+H is already reserved there is no harm forcing toggle local r9k to be rebound to it for every user.


this->tryAddDefault(addedHotkeys, HotkeyCategory::Window,
Expand Down
Loading