Added links to twitchemotes.com to Twitch emotes' context menus #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
approved these changes
Nov 22, 2020
|
wait how I didn't do anything |
1 task
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Aug 8, 2021
Now we're on commit a216e11; Changes from upstream we've pulled: - Minor: Remove TwitchEmotes.com attribution and the open/copy options when right-clicking a Twitch Emote. (Chatterino#2214, Chatterino#3136) - Minor: Strip leading @ and trailing , from username in /user and /usercard commands. (Chatterino#3143) - Minor: Display a system message when reloading subscription emotes to match BTTV/FFZ behavior (Chatterino#3135) - Bugfix: Moderation mode and active filters are now preserved when opening a split as a popup. (Chatterino#3113, Chatterino#3130) - Bugfix: Fixed a bug that caused all badge highlights to use the same color. (Chatterino#3132, Chatterino#3134) - Dev: Renamed CMake's build option `USE_SYSTEM_QT5KEYCHAIN` to `USE_SYSTEM_QTKEYCHAIN`. (Chatterino#3103) - Dev: Add benchmarks that can be compiled with the `BUILD_BENCHMARKS` CMake flag. Off by default. (Chatterino#3038) - Dev: Allow building against Qt 5.11 (Chatterino#3105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
As discussed on pajlada's stream earlier today, I added a link to context menus pointing to
twitchemotes.com/emotes/%1. I am aware that links might sometimes not work in some weird edge-cases (e.g. event emotes from qa_tw_partner), but I don't think we have any other alternative than twitchemotes.com for Twitch emote links and I think it's decent in general and I was missing similar functionality to quickly get emote link with some more imformation than just a .jpg file from regular sizes links.