Add custom hotkeys.

[Mm2PL]

Pull request checklist:

• CHANGELOG.md was updated, if applicable

Description

This pull request adds custom hotkeys to Chatterino.

• Closes Custom hotkeys #1592,
  Definitely one of those PRs which you squash and merge.

TODO

• Add defaults for hotkeys.
• Make it add new default hotkeys.
• Move all hotkeys/menu actions to new system. Done?
  • [-] Fucking Ctrl+C not doable with current systems and knowledge
• Add user interface. (another pr?)
  • new settings tab
  • modifying hotkeys
  • saving hotkeys
• Add actions for menu items
• Implement usage of HotkeyController::shortcutsForScope() in
  • EmotePopup
  • SelectChannelDialog (Escape => close, Return => accept, Ctrl+Tab => next tab, Ctrl+Shift+Tab => prev tab)
  • SettingsDialog (Ctrl+F => search in settings)
  • Split
  • SplitInput (figure out how to override default shortcuts from QTextEdit)
  • UserInfoPopup (Escape => close)
  • Window
  • Window debug shortcuts, is this even worth it?
  • non-obvious actions
  • Something else?
• Bind commands to a hotkey. It's easy enough and will allow for less code duplication.
• Make sure to deprecate the old shortcut creation methods.
• fix delet
• Add developer docs on adding new hotkeys
• live reloading
• Add usage documentation Add Documentation for custom hotkeys wiki#57
• Check if I broke : and @-completion menus, with ↑ and ↓.
• Make tab-completion use new system
• MAKE SURE TO TEST WITH WEIRD KEYBOARD LAYOUTS like Dvorak, Cyrillic keyboards, etc.
  • I checked the Dvorak layout (Linux/X11), works exactly as before this
  • I checked Russian layout (Linux/X11), works exactly as before this
  • needs Wayland testing for Dvorak
  • boring_nick tested Cyrillic keyboards on wayland needs Wayland testing for Russian or other Cyrillic keyboard
  • needs Windows testing for Dvorak
  • needs Windows testing for Russian or other Cyrillic keyboard
  • LosFarmosCTL tested Dvorak keyboards on MacOS needs MacOS testing for Dvorak
  • LosFarmosCTL tested Cyrillic keyboards on MacOS needs MacOS testing for Russian or other Cyrillic keyboard
• Get pajlada to review this monster pepeLaugh
• fourtf said he was gonna look at it PauseChamp
• Fix what he found
• Profit?

Testing

If you want to test out functionality introduced in this PR:

1. Download the latest artifact or compile it yourself.

2. Start Chatterino (preferably on another 'profile').

   • cross-platform: use the modes file.
   • On Linux you can set XDG_DATA_HOME=/path/to/directory to have a separate configuration for your Chatterino.
   • Windows and Mac: 🤷

3. Close it.

4. You don't have to edit settings manually, since there is a UI. Edit hotkeys in your settings.json file.
   - As per Custom hotkeys #1592 a hotkey is an object that looks like this:

{"scope": "split", "action": "delete", "keySequence": "Ctrl+W", "arguments": []}

5. Hotkeys hot-reload Start Chatterino again and try out your new hotkey.

Definitions

• a keycombo or keybinding is a bunch of keys you press on the keyboard,
• a shortcut is an underlying Qt QShortcut instance.
• a hotkey is a user-configurable 'template' for creating shortcuts.

[Mm2PL]

I don't see any more major changes happening to this PR, so I'm marking it as ready for review. However there is still some work to be done: moving things to the new custom hotkeys system.

[pajlada]

system

By moving things to the new system, you mean moving existing hotkeys to the new custom hotkeys system?

[pajlada]

Made a PR to your PR with some thoughts: Mm2PL#22

[pajlada]

Looks good so far 👍

[Felanbird]

Crash is fixed.

same commit hopping settings thing yadda yadda

[zneix]

Since the crash is fixed and all other nitpicks, typos I managed to find are taken care of I think I'm OK with approving this PR 🐍

[Felanbird]

[ilya-zlobintsev]

[Mm2PL]

monkaGIGA

[anqueue]

I think ill try out the new nightly, surely nothing will go wrong

[xHeaveny]

wow