-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove normalizing of splits #2548
Conversation
Could not find any benefit of normalization, but we lost information and splits got resized to bigger than they should
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have input on the changelog entry unfortunately 🤷♂️
Without this fixWith this fixThere was a single change in the "width flex" here once after fixing but I can't reproduce it so that might've been me fatfingering the split size TL;DR: Looks good to me! |
I recommend this fix instead: #2554 |
|
What do I need to do to get this merged? This PR seems to have less regressions than fourtf's and personally less code is more IMO. |
fourtf's PR #2554 has been updated and fixes all issues now, so I'll go ahead and close this issue. Thanks for bringing the issue to our attention! |
Could not find any benefit of normalization, but splits got resized to bigger than they should.
Fixes #2362
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
I'm testing this on my machine for now, but I can't see any regressions with this and I have a pretty big split setup with like 3 columns and each having 3-4 rows