Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom FrankerFaceZ VIP badges #2628

Merged
merged 6 commits into from
Apr 17, 2021

Conversation

zneix
Copy link
Collaborator

@zneix zneix commented Apr 15, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

your API is shit

Closes #2627

@zneix zneix marked this pull request as ready for review April 16, 2021 17:46
@zneix
Copy link
Collaborator Author

zneix commented Apr 16, 2021

Since these VIP badges are a bit different from mod badges (that were just white pixels on green background) - they are custom 72x72 images with no required background or anything, this means it could be sometimes difficult to distinguish between those and other badges like subscriber ones. Should we add a setting for those?

Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks and works as expected.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Will rebase master onto this branch and merge it in after #2623

@pajlada pajlada merged commit ed7d1a8 into Chatterino:master Apr 17, 2021
@zneix zneix deleted the feature/add-ffz-vip-badges branch April 17, 2021 13:28
@zneix zneix mentioned this pull request Apr 17, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom VIP Badges (New FrankerFaceZ Feature)
3 participants