Image uploader mime filter uses urls but doesn't check them #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
reviewed
Jun 6, 2021
Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
|
I will test this out tomorrow |
pajlada
approved these changes
Jun 13, 2021
There was a problem hiding this comment.
With @RAnders00 's approval I approve this! Thanks for the fix!
…ut_doesnt_check_them
pajlada
deleted the
fix/image_uploader_mime_filter_uses_urls_but_doesnt_check_them
branch
zneix
referenced
this pull request
in SevenTV/chatterino7
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Attempt to fix #1688 @RAnders00 please check if it works