-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add username autocompletion popup menu #2866
Add username autocompletion popup menu #2866
Conversation
Emote and username autocompletion menus work as intended for me. One thing about the appearance. I think it would be nice to have some sort of indicator like DankChat does to indicate that it is a person. I provided some examples below: Also the username doesn't seem to be vertically centered. |
I dislike the code duplication. I would probably have reused the existing :-popup code and allowed it to show text without images. I haven't tested the functionality yet. |
Not sure about this. The web chat equivalent contains only text, and unlike the DankChat example you provided, here it is clear when you are auto completing an emote vs a username based on the prefix used. Open to more opinions about this though.
I mostly agree, it just wasn't instantly obvious what the best way to combine this with the existing emote menu is, and I wanted to get something that works quickly. I can definitely try to do some more combining of the functionality and improve the code. If you have any more specific ideas I'd like to hear them. |
I combined the code for the emote completion menu and the new username menu, now definitely test the emote completion as well when testing as it is handled by the same code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I don't think we need to differentiate between users and emotes the same way DankChat does considering these two popups are activated in different ways (@
for user completion and :
for emote completion).
Now we're on commit d6b5921; Changes from upstream we pulled: - Major: Added username autocompletion popup menu when typing usernames with an @ prefix. (Chatterino#1979, Chatterino#2866) - Minor: The /live split now shows channels going offline. (Chatterino#2880) - Minor: Now shows deletions of messages like timeouts (Chatterino#1155, Chatterino#2841, Chatterino#2867, Chatterino#2874) - Bugfix: Moderation buttons now show the correct time unit when using units other than seconds. (Chatterino#1719, Chatterino#2864) - Bugfix: Fixed bit and new subscriber emotes not (re)loading in some rare cases. (Chatterino#2856, Chatterino#2857)
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
This PR adds a popup menu for autocompleting usernames with an '@' prefix, similar to the existing one for emotes with ':'.
When testing, also test the emote autocompletion menu, as this addition can affect it, and the implementation is also inspired by it.
Also looking for feedback on the appearance of the menu.
Closes #1979