Use an exponential backoff when deciding how long we need to wait for reconnects #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
force-pushed
the
fix/reconnect-delay
branch
from
2e70ae4 to
5c39c4d
Compare
leon-richardt
requested changes
Jun 13, 2021
Co-authored-by: Leon Richardt <leon.richardt@gmail.com>
pajlada
changed the title
leon-richardt
approved these changes
Jun 17, 2021
zneix
approved these changes
Jun 20, 2021
Mm2PL
approved these changes
Jun 20, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jun 25, 2021
Now we're on commit 0021290; Changes from upstream we pulled: - Bugfix: Fix reconnecting when IRC write connection is lost (Chatterino#1831, Chatterino#2356, Chatterino#2850, Chatterino#2892) - Bugfix: Fixed subscription emotes showing up incorrectly in the emote menu. (Chatterino#2905) Changes added in Chatterino7 only: - Major: Added 7tv badges. (2154981) - Minor: Fixed potential issues preventing 7tv emotes from loading (c0b1117)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Instead of always waiting ~15 seconds for a reconnect, we now follow the guidelines from https://dev.twitch.tv/docs/irc/guide#re-connecting-to-twitch-irc and increase our reconnect delays exponentially.
Our reconnect delay starts at 1 second and caps out at 16 seconds.
Closes #2869