-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability to add nicknames for users #2981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work so far, some general notes:
- In terms of naming, I'm wondering if "alias" is the best option for users, as opposed to something like "nickname". I'm fine with alias but wondering what others think.
- I think something like this should be controllable through the usercard, like how the similar BTTV feature works. Maybe a usercard button that allows to add or edit your alias for that user. I suppose this could also be implemented on its own after this is merged though.
I'm only doing a base implementation and am honestly not sure if it's worth implementing such a feature in the first place since it's a lot of work for little gain since it only adds a tiny convenience for a feature you'll probably rarely use (at least the way I see it). You can even press the copy username button in the usercard to get the username. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some things I found in the code. One behvior I find weird is that @-s aren't transformed to use aliases, but that can be added later in another small PR.
Co-authored-by: Mm2PL <mm2pl+gh@kotmisia.pl>
To explain a bit about my alias implementation. Making the names actual aliases in the code would mean we'd have to separate aliases and normal usernames and you'll get issues where someone sets the alias to a user that already exists and it feels like it's such a mess for features most people simply won't use. Searching with |
Now we're on commit 3cb1e51; Changes from upstream we pulled: - Major: Added the ability to add nicknames for users. (#137, Chatterino#2981)
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Alias for usernames in twitch chat.
Closes #137