Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to add nicknames for users #2981

Merged
merged 17 commits into from
Jul 31, 2021
Merged

Conversation

apa420
Copy link
Collaborator

@apa420 apa420 commented Jul 8, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Alias for usernames in twitch chat.

Closes #137

@apa420 apa420 marked this pull request as ready for review July 8, 2021 20:49
Copy link
Contributor

@talneoran talneoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work so far, some general notes:

  • In terms of naming, I'm wondering if "alias" is the best option for users, as opposed to something like "nickname". I'm fine with alias but wondering what others think.
  • I think something like this should be controllable through the usercard, like how the similar BTTV feature works. Maybe a usercard button that allows to add or edit your alias for that user. I suppose this could also be implemented on its own after this is merged though.

CHANGELOG.md Outdated Show resolved Hide resolved
src/providers/twitch/TwitchMessageBuilder.cpp Outdated Show resolved Hide resolved
src/providers/twitch/TwitchMessageBuilder.cpp Outdated Show resolved Hide resolved
src/widgets/settingspages/AliasesPage.cpp Outdated Show resolved Hide resolved
@apa420
Copy link
Collaborator Author

apa420 commented Jul 8, 2021

I think something like this should be controllable through the usercard, like how the similar BTTV feature works. Maybe a usercard button that allows to add or edit your alias for that user. I suppose this could also be implemented on its own after this is merged though.

I'm only doing a base implementation and am honestly not sure if it's worth implementing such a feature in the first place since it's a lot of work for little gain since it only adds a tiny convenience for a feature you'll probably rarely use (at least the way I see it).

You can even press the copy username button in the usercard to get the username.

@Mm2PL Mm2PL self-requested a review July 14, 2021 17:37
@zneix zneix self-requested a review July 14, 2021 17:38
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some things I found in the code. One behvior I find weird is that @-s aren't transformed to use aliases, but that can be added later in another small PR.

src/widgets/dialogs/SettingsDialog.cpp Outdated Show resolved Hide resolved
src/controllers/aliases/AliasesName.hpp Outdated Show resolved Hide resolved
src/controllers/aliases/AliasesName.hpp Outdated Show resolved Hide resolved
@apa420
Copy link
Collaborator Author

apa420 commented Jul 23, 2021

To explain a bit about my alias implementation.
I personally would only want alias in the most simple sense possible, the name of the chatter gets changed from one name to another client sided.
For example my friend Che has the username just_che on twitch and I'd like it to just display Che for me personally and I don't really care about auto completing it or anything else.

Making the names actual aliases in the code would mean we'd have to separate aliases and normal usernames and you'll get issues where someone sets the alias to a user that already exists and it feels like it's such a mess for features most people simply won't use.

Searching with user: auto completion etc won't work with this pr nor do I think the feature should support it.

@gempir
Copy link
Contributor

gempir commented Jul 31, 2021

The highlights menu uses the terminology "Username" instead of "Name" so I think the column name here should be adjusted

image

@pajlada pajlada changed the title Alias feature Added the ability to add nicknames for users Jul 31, 2021
@pajlada
Copy link
Member

pajlada commented Jul 31, 2021

The highlights menu uses the terminology "Username" instead of "Name" so I think the column name here should be adjusted

image

Fixed

image

@pajlada pajlada merged commit 3cb1e51 into Chatterino:master Jul 31, 2021
zneix added a commit to SevenTV/chatterino7 that referenced this pull request Jul 31, 2021
Now we're on commit 3cb1e51; Changes from upstream we pulled:

- Major: Added the ability to add nicknames for users. (#137, Chatterino#2981)
@zneix zneix mentioned this pull request Aug 4, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add alias feature / tagging users
6 participants