Added informative messages on issues related to recent-messages #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
reviewed
Jul 17, 2021
Comment on lines
818
to
823
| if (errorCode == "channel_not_joined") | ||
| { | ||
| shared->addMessage(makeSystemMessage( | ||
| "Recent-messages API isn't currently joined to " | ||
| "this channel (in progress or due to an issue).")); | ||
| } |
There was a problem hiding this comment.
If the errorCode is channel_not_joined and messages is not empty we can deduce that the bot was joined previously but has disconnected, we can inform the user that there may be gaps in the message history: Message history service recovering, there may be gaps in the message history
If the errorCode is channel_not_joined and messages is empty I don't think we should print anything, because there's no difference for you vs for the next user who joins and sees nothing other than "Wow! You were the first user here with Chatterino! Congratulations! 🚀"
There was a problem hiding this comment.
Should be resolved in 3f1d81f, let me know if it's good enough.
And make it not appear if channel is joined for the first time, see #3029 (comment)
pajlada
reviewed
Jul 18, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jul 25, 2021
Now we're on commit 770b9f2; Changes from upstream we pulled: - Minor: Added informative messages for recent-messages API's errors. (Chatterino#3029) - Minor: Added section with helpful Chatterino-related links to the About page. (Chatterino#3068) - Bugfix: Fixed PubSub not properly trying to resolve pending listens when the pending listens list was larger than 50. (Chatterino#3037) - Bugfix: Copy buttons in usercard now show properly in light mode (Chatterino#3057) - Bugfix: Fixed comma appended to username completion when not at the beginning of the message. (Chatterino#3060) - Bugfix: Fixed bug misplacing chat when zooming on Chrome with Chatterino Native Host extension (Chatterino#1936) - Dev: Disabled update checker on Flatpak. (Chatterino#3051) - Dev: Add logging for HTTP requests (Chatterino#2991)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Added an generic error message if request to recent-messgaes fails, including status code of the HTTP request.
Added an informative message telling user that recent-messages bot isn't currently joined in the channel, for which they requested historical messages, explaining that messages we received might be incomplete.
Closes #2870