Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing information in locally-generated IRC messages #3203

Merged
merged 3 commits into from
Aug 29, 2021

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Aug 27, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Adds a link onto the username which opens a usercard, messageText/searchText, loginName/displayName.
Closes #1422

@Mm2PL Mm2PL requested a review from zneix August 27, 2021 10:03
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as intended. 👍

This PR also fixes the last part of #1422

@zneix
Copy link
Collaborator

zneix commented Aug 27, 2021

Code looks splendid, I'll build and test the PR once I'm back home. So far, a big BroBalt

@pajlada pajlada enabled auto-merge (squash) August 29, 2021 11:46
@pajlada pajlada merged commit cd2923c into Chatterino:master Aug 29, 2021
@pajlada pajlada deleted the fix/irc_self_messages branch August 29, 2021 12:05
zneix added a commit to SevenTV/chatterino7 that referenced this pull request Aug 29, 2021
Now we're on commit 5f8106e; Changes from upstream we've pulled:

- Minor: Colorizing usernames on IRC, originally made for Mm2PL/dankerino (Chatterino#3206)
- Bugfix: Fixed own IRC messages not having metadata and a link to a usercard. (Chatterino#3203)
@pajlada pajlada mentioned this pull request Oct 31, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search doesn't work in IRC channels
4 participants