Fix 'First Message' scrollbar highlights not being disabled #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felanbird
approved these changes
Oct 30, 2021
pajlada
approved these changes
Oct 30, 2021
There was a problem hiding this comment.
Implementation looks good, but the check whether or not to render the highlight makes me sick (not your fault).
I've gone ahead and made this PR to flatten the scroll highlight iteration, which lets us early-out before the rendering that's done last.
Once #3326 has been merged into the main branch, I'll update this PR branch for use with this new flattened method.
…crollbar-highlights
|
Thanks for your contribution @1xelerate! As a first-time contributor, you can now add yourself to the contributors list that's shown inside the application. To do so, open a new PR where you modify the |
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Oct 30, 2021
Now we're on commit b4b7450; Changes from upstream we've pulled: - Minor: Clean up chat messages of special line characters prior to sending. (Chatterino#3312) - Bugfix: Fixed `First Message` scrollbar highlights not being disabled. (Chatterino#3325) - Dev: Add GitHub action to test builds without precompiled headers enabled. (Chatterino#3327)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Added const method
isFirstMessageHighlight()to check if a highlight is a first message highlight similar toisRedeemedHighlight(). Considered this new method and whether or not first message highlights were enabled in the settings while painting scrollbar highlights.Bug can be reproduced by looking at a chat with first message highlights, going into the settings and disabling first message highlights and then observing that the scrollbar still shows the highlights for the first messages.
Closes #3317