Implement workaround for combined emoji

[Mm2PL]

Pull request checklist:

• CHANGELOG.md was updated, if applicable

Description

Closes #3384

[pajlada]

Adding comment here since it's been kept in chat only for now: There's some issue with this on Windows only, some error with parsing the unicode regular expression or something

[Felanbird]

it works on windows now 👍

[Felanbird]

Incoming whispers doesn't work on windows so nobody randomly merge this :)

🤏 windows

[LosFarmosCTL]

Was this tested on macOS or should I take a look at it when I am back home tomorrow?

[Felanbird]

Was this tested on macOS or should I take a look at it when I am back home tomorrow?

I assume not so you can go ahead and test it 🙂

[LosFarmosCTL]

Works fine on macOS

[LosFarmosCTL]

Ok, I did some more testing and while the behaviour itself does not create any issues on macOS I found a general problem with outgoing whispers.

Inside CommandController.cpp any message that is recognised as being a whisper command will be redirected and sent directly into sendMessage() of the underlying AbstractIrcServer, so the code for replacing \u200D inside of TwitchChannel.cpp will never get executed:

chatterino2/src/controllers/commands/CommandController.cpp

Lines 64 to 70 in dfa3818

	void sendWhisperMessage(const QString &text)
	{
	// (hemirt) pajlada: "we should not be sending whispers through jtv, but
	// rather to your own username"
	auto app = getApp();
	app->twitch.server->sendMessage("jtv", text.simplified());
	}

That entire behaviour seems a bit odd to me, why even redirect the message in the first place, but no idea if there is an underlying reason for it. Anyhow, it breaks the implementation of this PR and needs to be addressed somehow.

[Mm2PL]

@Felanbird I made sending it work in sent whispers. Feel free to merge whenever! miniDank

Incoming whispers work too.

[Felanbird]

Whispers are fixed on windows, and since this has been tested on all 3 OS I'm going to go ahead and merge it 👍

[Felanbird]

Oh also since we had a minor discussion about it, this PR unfortunately did not accidentally fix Arabic rendering.