Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu option to open the user's channel from a usercard #3486

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Jan 11, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Adds an option to the menu after right clicking the avatar to open the channel in a new popup window. Not exactly the best UX but works. Ported as-is from Dankerino pajaDent

@Mm2PL Mm2PL requested a review from pajlada January 11, 2022 19:43
@zneix zneix self-assigned this Jan 12, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Okayge

Co-authored-by: Paweł <zneix@zneix.eu>
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise I've used this in Dankerino before and I do think it could be useful, once and a while I wouldn't mind quickly hopping into someone's chat in this manor.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will sort out conflicts and merge in after #3566

@Felanbird Felanbird enabled auto-merge (squash) February 13, 2022 01:20
@Felanbird Felanbird merged commit ad82466 into Chatterino:master Feb 13, 2022
@pajlada pajlada deleted the feature/open_channel_in_popup_window_from_usercard branch February 13, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants