Remove first timestamp from genereated AutoMod queue messages #3503
Conversation
…ch it doesn't show it either Remove timestamp from AutoMod, for style purposes and because on Twitch it doesn't show it either. Same goes for the new "low-trust-users" messages.
karl-police
changed the title
|
Could you provide a before and after screenshot? |
Sure. Before: After: Preferably at some point, we could reduce the gap between the modmail message and the users message that would have been sent in the chat. @pajlada do you have more of these "builder.emplace" "Elements" or is it based of a template from Qt on something, couldn't find that. So that I could look into more stuff for the UI. |
https://github.com/Chatterino/chatterino2/blob/master/src/messages/MessageBuilder.hpp#L65-L75 That's where we've defined the emplace function that you used just now - all it does is add a Message Element to the Message Builder. It's a semi-common pattern we follow where we have builders |
|
I thought that we had added the timestamps on reward message to be consistent with automod |
Possibly - we will want to review other "message headers" and see about removing the timestamp of those too I think |
|
Thanks for your contribution! As a first-time contributor, you can now add yourself to the contributors list that's shown inside the application. To do so, open a new PR where you modify the |
Now we're on commit 1d272c3; Changes from upstream we've pulled - Minor: Make animated emote playback speed match browser (Firefox and Chrome) behaviour. (Chatterino#3506) - Minor: Add feedback when using the whisper command `/w` incorrectly. (Chatterino#3439) - Minor: Add feedback when writing a non-command message in the `/whispers` split. (Chatterino#3439) - Minor: Opening streamlink through hotkeys and/or split header menu matches `/streamlink` command and shows feedback in chat as well. (Chatterino#3510) - Minor: Removed timestamp from AutoMod messages. (Chatterino#3503) - Minor: Added ability to copy message ID with `Shift + Right Click`. (Chatterino#3481) - Bugfix: Fixed crash that would occur if the user right-clicked AutoMod badge. (Chatterino#3496) - Bugfix: Fixed being unable to drag the user card window from certain spots. (Chatterino#3508) - Bugfix: Fixed being unable to open a usercard from inside a usercard while "Automatically close user popup when it loses focus" was enabled. (Chatterino#3518) - Bugfix: Usercards no longer close when the originating window (e.g. a search popup) is closed. (Chatterino#3518)
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Remove timestamp from AutoMod, for style purposes and because on Twitch it doesn't show it either. The only thing where the timestamp should show is from the message itself.
Same things is with the "low-trust-users" messages.