Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added margin to emote search #3543

Merged
merged 4 commits into from
Mar 26, 2022
Merged

Added margin to emote search #3543

merged 4 commits into from
Mar 26, 2022

Conversation

qooq69
Copy link
Contributor

@qooq69 qooq69 commented Jan 26, 2022 •
edited
Loading

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Closes #3525

Before:
image
After:
image

@Mm2PL Mm2PL self-requested a review January 26, 2022 13:19
Felanbird
Felanbird reviewed Jan 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Felanbird
Felanbird approved these changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does indeed add a margin to emote search.

zneix
zneix reviewed Jan 29, 2022
View reviewed changes
Copy link
Collaborator

@zneix zneix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming layout2 is quite random, could be something more descriptive.

Mm2PL
Mm2PL approved these changes Jan 29, 2022
View reviewed changes
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality 👍
Code is okay

@pajlada pajlada enabled auto-merge (squash) March 26, 2022 13:17
@pajlada pajlada merged commit 3c46572 into Chatterino:master Mar 26, 2022
@Felanbird Felanbird mentioned this pull request Mar 28, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zneix zneix zneix left review comments

@Felanbird Felanbird Felanbird approved these changes

@Mm2PL Mm2PL Mm2PL approved these changes

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A margin should be added to the emote search bar
5 participants
@qooq69 @pajlada @Mm2PL @Felanbird @zneix