Fixed automod and unban messages showing when moderation actions were disabled #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zneix
approved these changes
Jan 28, 2022
Mm2PL
changed the title
zneix
approved these changes
Jan 28, 2022
Felanbird
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
I'm fine with merging this in, because it does fix the issue in question, and after watching Poki struggle to drag a usercard on stable, the faster we can get her on nightly the better it looks on us.
But, there are 2 issues generated from this change that will need to be fixed:
- The ghost of the hidden automod message still exists until the next message is sent (probably windows only)
- Automod messages are now searchable with
is:timeoutwhen the setting is enabled (is this an issue? it actually sounds like a useful bug)
zneix
deleted the
fix/hide_automod_and_unban_messages_from_pubsub_properly
branch
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jan 28, 2022
Now we're on commit ddbeb35; Changes from upstream we've pulled - Bugfix: Disabled /popout and /streamlink from working in non-twitch channels (e.g. /whispers) when supplied no arguments. (Chatterino#3541) - Bugfix: Fixed automod and unban messages showing when moderation actions were disabled (Chatterino#3548)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
I added appropriate flags to AutoMod messages and made the hideModerationActions setting ignore Untimeout (unban) messages. Fixes #3547.
Note: this does not hide messages notifying users that their message was held, just the moderation variants.