Added support for Twitch's Chat Replies #3722

dnsge · 2022-05-10T03:13:22Z

Description

Adds message reply thread support (https://help.twitch.tv/s/article/chat-basics?language=en_US#replies)

Only supported for TwitchChannels
Upon clicking the reply button, the user is presented with a reply dialog that shows the message thread and allows for typing responses with the same features as the standard input box (emote autocomplete, for example)
New replies are automatically added to the reply dialog similar to the user info dialog
/reply <username> <message> command sends a reply to the given user's most recent message

Design choices:

The message being replied to is rendered, but only the first line like in Twitch
The message being replied to does NOT render emotes and shows the raw text instead

The reply button

I initially tried only rendering the reply button when hovering a message, but the message rendering pipeline makes this pretty much impossible. The tiny reply button was the best compromise to having an accessible but not too intrusive option.

The reply buttons are not visible by default but can be enabled in settings if a user wants a single-click way to reply to a message.

Screenshots

Expand

Reply to message option:

Inline message replying

Message with reply:

Message thread dialog:

Reply buttons enabled:

Closes #1912

Pull request checklist:

CHANGELOG.md was updated, if applicable

src/providers/twitch/TwitchMessageBuilder.cpp

src/widgets/dialogs/ReplyThreadPopup.cpp

kornes · 2022-05-11T19:57:21Z

From 30mins testing:

icons visible at all times are no go, too intrusive
icons don't scale well with zoom changes screen
window titles should include channel of origin
allowing single instance of reply window per target username would be cool to minimize mess
we shouldn't be allowed to reply own messages
full thread view (with replies from both sides) shouldn't include "Replying to" rows
i would make whole SingleLineTextElement clickable to open thread view for easier access

Overall looks good, but I think it would be better to remove icons/settings altogether from initial implementation in this PR. Context menu link to initiate reply and whole "Replying to @user" row clickable to answer, would be good in my book.

Mm2PL · 2022-05-11T20:11:25Z

allowing single instance of reply window per target username (or even per channel) would be cool to minimize mess

There is no limit to usercards, search windows. I don't see why this should have a limit.

we shouldn't be allowed to reply own messages

Why? IRC doesn't care about this. Webchat does, but webchat isn't the one-and-only chat experience.

dnsge · 2022-07-23T20:59:02Z

random note: I noticed because of this PR that the Sending message as felanbird... text was not centered, this PR happens to center it which will be slightly annoying at first for people who do notice it, but is likely correct.

This was actually a bug that I did not notice... The HBox that contains the "Replying to" label was still taking up space while its children were not visible. I've now fixed that problem so the message input box looks the same as master when not replying.

pajlada · 2022-07-24T12:45:07Z

This is the patch required to fix the tab/autocomplete focus lose issue:

diff --git a/src/widgets/helper/ChannelView.cpp b/src/widgets/helper/ChannelView.cpp
index 0b3459b3..09696c5b 100644
--- a/src/widgets/helper/ChannelView.cpp
+++ b/src/widgets/helper/ChannelView.cpp
@@ -163,7 +163,7 @@ ChannelView::ChannelView(BaseWidget *parent, Split *split, Context context)
     // and tabbing to it from another widget. I don't currently know
     // of any place where you can, or where it would make sense,
     // to tab to a ChannelVieChannelView
-    this->setFocusPolicy(Qt::FocusPolicy::StrongFocus);
+    this->setFocusPolicy(Qt::FocusPolicy::ClickFocus);
 }
 
 void ChannelView::initializeLayout()

I touched this place very recently and felt like something was wrong in the Focus Policy that was set for ChannelView. Would need to be tested a bit extra most likely but worked as expected for me on Arch Linux btw

src/singletons/Settings.hpp

Felanbird · 2022-07-24T18:36:19Z

Tab focus issue is resolved with the ClickFocus patch, focus setting should still be disabled by default as it does not make sense for an input box to be removed on loss of focus, as well as it's impossible to use the emote menu with that setting enabled.

pajlada

Awesome work!

Mm2PL

Found only a tiny visual bug, I'm fine with merging as is and fixing this at a later date.
With closing reply threads on lost focus:

Without:

dnsge · 2022-07-30T13:16:30Z

Found only a tiny visual bug

This isn't actually a visual bug but an intentional change. When close-on focus loss is true, we use a frameless window. On non-linux platforms, we won't have any area to drag the popup around because the ChannelView and SplitInput take up the entire popup window. So instead, we introduce a margin to allow the user to drag the popup around.

https://github.com/dnsge/chatterino2/blob/2ea0d8c7c92836c84d363bc75275b647f4e8f7ab/src/widgets/dialogs/ReplyThreadPopup.cpp#L92-L93

We could guard this behavior in a macro because we don't do frameless windows on linux:

https://github.com/dnsge/chatterino2/blob/2ea0d8c7c92836c84d363bc75275b647f4e8f7ab/src/widgets/DraggablePopup.cpp#L11-L21

But like you said, we can do this at a later time. With the amount of code that was touched in this change, I'm sure we'll find more issues to fix once this change is on nightly.

23rd · 2022-07-31T09:46:08Z

src/providers/twitch/TwitchMessageBuilder.cpp

+                if (hasLocalizedName)
+                {
+                    usernameText = localizedName;
+                }
+                else
+                {
+                    usernameText = username;
+                }
+            }
+            break;
+
+            default:
+            case UsernameDisplayMode::UsernameAndLocalizedName: {
+                if (hasLocalizedName)
+                {
+                    usernameText = username + "(" + localizedName + ")";
+                }
+                else
+                {
+                    usernameText = username;
+                }


Can be simplified with a ternary operator.

The code is just copy-pasted from another function since it needed to be reused, so not super in scope of this PR to fix it

I would argue that using ternary operators here wouldn't necessarily make the code more readable

23rd · 2022-07-31T09:53:34Z

src/widgets/splits/SplitInput.hpp

@@ -109,6 +137,7 @@ private slots:
    void editTextChanged();

    friend class Split;
+    friend class ReplyThreadPopup;


Is it needed here?

This is necessary for ReplyThreadPopup to be able to call giveFocus on the SplitInput

src/common/Channel.cpp

zneix · 2022-07-31T10:47:53Z

thanks for caring about me at all

dnsge added 19 commits May 9, 2022 21:11

Add MessageThread functionality

d9af39c

Add SingleLineTextElement

74152dd

Add reply message rendering

64c4661

Add flags.reply to filters

c9c9c97

Remove @username prefix from reply

13262b7

Fix 'class' -> 'struct'

6123740

Add reply assets

ce257eb

Add floating button rendering

2e2f04b

Add simple ReplyThreadPopup

500903d

Conditional reply button rendering, some fixes

d6ff6a8

Add mostly functional reply sending

1c369db

Automatically add new replies to popup

db6c547

Add reply placeholder text

5344ea1

Add reply context menu item

f546e84

Add setting to hide/show message buttons

f18f43f

Update CHANGELOG.md

85688fa

buildfix: Add QSize with operator+

47aab27

buildfix: include QPainterPath

32af6f5

buildfix: Maybe check if your build fix works before pushing?

49a783b

dnsge marked this pull request as ready for review May 11, 2022 05:58

zneix previously requested changes May 11, 2022

View reviewed changes

src/providers/twitch/TwitchMessageBuilder.cpp Outdated Show resolved Hide resolved

src/widgets/dialogs/ReplyThreadPopup.cpp Outdated Show resolved Hide resolved

dnsge added 4 commits May 11, 2022 14:26

Exclude replied message from copy

a1ce259

Don't omit @username in reply

306f7a7

Conditionally show reply input

51e478d

Consistent vbox spacing

90f0b72

dnsge added 3 commits May 11, 2022 16:04

Render emojis properly in replies

2e7d10f

Fix reply selection with mouse

327c461

Clicking replies brings up thread

fd6e520

dnsge added 4 commits July 23, 2022 16:55

Correctly detect changes to reply @name prefixes

ea033ff

Revert hotkey handler extraction

841b3d2

Check for empty reply like with regular messages

c0049f0

Merge branch 'master' into reply-threads

9c933cc

Attempt fix tab/autocomplete focus lose issue

8f6b943

Felanbird reviewed Jul 24, 2022

View reviewed changes

src/singletons/Settings.hpp Outdated Show resolved Hide resolved

dnsge added 2 commits July 29, 2022 22:55

Change autoCloseThreadPopup default to false

567576b

Fix copy/paste error

6203b6a

Felanbird approved these changes Jul 30, 2022

View reviewed changes

pajlada requested a review from Mm2PL July 30, 2022 09:58

pajlada added 2 commits July 30, 2022 12:18

Update changelog entry

de18ebc

Merge remote-tracking branch 'origin/master' into reply-threads

2ea0d8c

pajlada approved these changes Jul 30, 2022

View reviewed changes

Mm2PL approved these changes Jul 30, 2022

View reviewed changes

23rd reviewed Jul 31, 2022

View reviewed changes

pajlada added 2 commits July 31, 2022 12:24

Merge branch 'master' into reply-threads

6776417

add warnings back

db7c5eb

pajlada changed the title ~~Add Message Reply Threads~~ Added support for Twitch's Chat Replies Jul 31, 2022

pajlada enabled auto-merge (squash) July 31, 2022 10:29

zneix requested changes Jul 31, 2022

View reviewed changes

src/common/Channel.cpp Show resolved Hide resolved

pajlada merged commit 20c974f into Chatterino:master Jul 31, 2022

dnsge deleted the reply-threads branch July 31, 2022 21:51

dnsge mentioned this pull request Oct 5, 2022

Add option to hide leading user mention in replies #4044

Closed

4 tasks

dnsge mentioned this pull request Jan 31, 2023

Display message being replied to above input box #4350

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for Twitch's Chat Replies #3722

Added support for Twitch's Chat Replies #3722

dnsge commented May 10, 2022 •

edited

Loading

kornes commented May 11, 2022 •

edited

Loading

Mm2PL commented May 11, 2022

dnsge commented Jul 23, 2022 •

edited

Loading

pajlada commented Jul 24, 2022

Felanbird commented Jul 24, 2022

pajlada left a comment

Mm2PL left a comment

dnsge commented Jul 30, 2022

23rd Jul 31, 2022

pajlada Jul 31, 2022

23rd Jul 31, 2022

pajlada Jul 31, 2022

zneix commented Jul 31, 2022

Added support for Twitch's Chat Replies #3722

Added support for Twitch's Chat Replies #3722

Conversation

dnsge commented May 10, 2022 • edited Loading

Description

The reply button

Screenshots

Pull request checklist:

kornes commented May 11, 2022 • edited Loading

Mm2PL commented May 11, 2022

dnsge commented Jul 23, 2022 • edited Loading

pajlada commented Jul 24, 2022

Felanbird commented Jul 24, 2022

pajlada left a comment

Choose a reason for hiding this comment

Mm2PL left a comment

Choose a reason for hiding this comment

dnsge commented Jul 30, 2022

23rd Jul 31, 2022

Choose a reason for hiding this comment

pajlada Jul 31, 2022

Choose a reason for hiding this comment

23rd Jul 31, 2022

Choose a reason for hiding this comment

pajlada Jul 31, 2022

Choose a reason for hiding this comment

zneix commented Jul 31, 2022

dnsge commented May 10, 2022 •

edited

Loading

kornes commented May 11, 2022 •

edited

Loading

dnsge commented Jul 23, 2022 •

edited

Loading