Fix Reply Text Showing In Reply Thread Popup #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableThere have been so many changes to the reply thread changelog entry (and this is a bugfix to a bugfix) that I really don't care if we don't add this PR to the changelog.
Description
#4092 Introduced the following bug:
The reply text is improperly rendered in the reply thread popup.
This PR fixes the bug. The bug itself is my fault because, during the (extensive) changes made to my original reply threads PR, I changed around how hiding the reply message elements worked. This change eliminates the
setRenderRepliesmethod which became unused at some point.Also: sorry for the unrelated change of extracting the accessing of setting values. I just couldn't leave the repeated calls that could easily be reused.