Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows build documentation #4413

Merged
merged 7 commits into from
Mar 4, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Feb 25, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

This moves CMake to be our top supported build method, with Qt creator
being lower priority now.

This was tested on a real Windows 10 machine from scratch.

Would appreciate some proof-reading, especially of the CMake part (it should be pretty short)

This moves CMake to be our top supported build method, with Qt creator
being lower priority now.
@Nerixyz Nerixyz mentioned this pull request Feb 27, 2023
1 task
@ScrubN
Copy link
Contributor

ScrubN commented Mar 1, 2023

BUILDING_ON_WINDOWS_WITH_VCPKG.md can also be updated.

  • Just last night I installed everything I did not already have (so not git or Desktop C++) and from start (before vcpkg) to having chatterino2.exe compiled I think it took about 44GB of storage space: 41GB for vcpkg/downloads, vcpkg/buildtrees, vcpkg/packages and 3GB for chatterino2/build.

  • Pwsh interprets the ; in 5.3 as denoting a new command, meaning the system environment variable editor (SystemPropertiesAdvanced.exe) must be used instead.

  • I personally think set VCPKG_ROOT=C:\path\to\vcpkg\ should be switched to set VCPKG_ROOT=<path to vcpkg> to match with cmake --build . --parallel <threads> --config Release right below

  • A shell restart is mandatory between Prerequisites and Building if vcpkg was just installed.

@pajlada pajlada merged commit 35ac9d5 into master Mar 4, 2023
@pajlada pajlada deleted the chore/update-windows-build-documentation branch March 4, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants