Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugin compilation error when using Qt 6 #4504

Merged
merged 2 commits into from
Apr 2, 2023
Merged

Fix plugin compilation error when using Qt 6 #4504

merged 2 commits into from
Apr 2, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Apr 2, 2023 •
edited
Loading

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Fixes a small compilation error (I introduced) that only shows up on Qt 6:

  • MSVC: error C3445: copy-list-initialization of 'QDebug' cannot use an explicit constructor
  • clang: Chosen constructor is explicit in copy-initialization - clang(selected_explicit_constructor)

The QDebug::QDebug(QString *) constructor is marked as explicit in Qt 6 and was marked as inline in Qt 5.

@Nerixyz Nerixyz changed the title Fix Compilation Error In Qt 6 Fix Compilation Error in Qt 6 Apr 2, 2023
@pajlada pajlada changed the title Fix Compilation Error in Qt 6 Fix plugin compilation error when using Qt 6 Apr 2, 2023
@pajlada pajlada merged commit 149399a into Chatterino:master Apr 2, 2023
@Nerixyz Nerixyz deleted the fix/msvc-thing branch April 2, 2023 21:08
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nerixyz @pajlada