Allow ChannelViews without a Split
#4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
13 tasks
Nerixyz
changed the title
Splits and allow them to be nullptrChannelViews without a Split
pajlada
reviewed
Dec 17, 2023
pajlada
approved these changes
Dec 17, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the references to splits kept by
ChannelViews,ReplyThreadPopups, andUserInfoPopups to be aQPointer<Split>. This way, they can't contain dangling pointers to the originalSplits. In turn, the following UB and potential crashes are prevented:Go to Messagein a user card/reply thread popup after the original split has been deleted.Split*inSplitInputwith aQPointer<Split>if there's no crash)This in turn makes it possible to create user cards and reply thread popups without a split. Also required for #4746.