Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signal connection nodiscard warnings #4818

Merged
merged 38 commits into from
Sep 16, 2023
Merged

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Sep 15, 2023

Description

  • Fix nodiscard warnings for SplitHeader split connections
  • Clean up SplitHeader's mode update code
  • SplitHeader: Ensure the layout is only created once
  • Clean up SplitInput signal connection handling
  • Clean up ReplyThreadPopup signal ignores
  • Clean up Application signal connections
  • Clean up AccountController signal connections
  • Clean up CommandController signal connections
  • Clean up NotificationController signal connections
  • Clean up Irc2 signal connections
  • Change IrcConnection's smartReconnect signal into a function
  • Fix signal connections in SelectChannelDialog
  • Clean up ChannelView signal connections
  • Clean up Split signal connections
  • Clean up HighlightingPage signal connections
  • Clean up IgnoresPage signal connections
  • Clean up ModerationPage signal connections
  • Clean up NotificationPage signal connections
  • Clean up KeyboardSettingsPage signal connections
  • Clean up FiltersPage signal connections
  • Clean up GeneralPageView signal connections
  • Clean up NicknamesPage signal connections
  • Clean up AccountsPage signal connections
  • Clean up CommandPage signal connections
  • Clean up UserInfoPopup signal connections
  • Clean up EmotePopup signal connections
  • Clean up TwitchAccountManager signal connections
  • Clean up Logging signal connections
  • Clean up TwitchIrcServer signal connections
  • Mini TwitchIrcServer.cpp refactor :tf:
  • Clean up AccountSwitchWidget signal connections when it gets destroyed
  • Clean up signal connection in WindowManager
  • Clean up InitUpdateButton signal connections
  • Clean up some TwitchChannel signal connections
  • TwitchChannel/Channel: Convert the messageRemovedFromStart signal into a virtual protected function
  • TwitchChannel: Refactor roomIdChanged into a function
  • random clang-format reformat on TwitchChannel::threads for some reason

These lifetimes are tied to the lifetime of the Split that owns the
SplitHeader, meaning the SplitHeader will die at the same time the Split does
This removes the need for the private `modeUpdateRequested_` signal
@pajlada pajlada force-pushed the chore/nodiscord-warnings branch from 6bbd09c to 58d8f12 Compare September 15, 2023 21:00
@pajlada pajlada marked this pull request as ready for review September 15, 2023 21:00
@pajlada pajlada force-pushed the chore/nodiscord-warnings branch from 58d8f12 to 959f6d9 Compare September 15, 2023 21:07
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Member Author

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pajlada pajlada enabled auto-merge (squash) September 16, 2023 09:59
@pajlada pajlada merged commit 8fe3af3 into master Sep 16, 2023
@pajlada pajlada deleted the chore/nodiscord-warnings branch September 16, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant