fix: Fix username tab completion without @ #4853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felanbird
approved these changes
Oct 1, 2023
There was a problem hiding this comment.
tested literally everything I could think of so we can get this done really for real this time
| test | works? | correct? |
|---|---|---|
| username tab completion with the @ setting disabled | yes | ✔️ |
| username tab completion with the @ setting enabled | no | ✔️ |
| @username tab completion with the @ setting disabled | yes | ✔️ |
| @username tab completion with the @ setting enabled | yes | ✔️ |
| colon emote menu tab completion | yes | ✔️ |
| emote tab completion with the onlyStartOfName setting enabled | yes | ✔️ |
| emote tab completion with the onlyStartOfName setting disabled | #4855 | ✔️ 1 |
| emote tab completion when emotes are disabled | yes | ✔️ |
command tab completion when the command starts with / |
yes | ✔️ |
command tab completion when the command doesn't start with / |
yes | ✔️ |
command tab completion when the command starts with an /, but the / was not included |
yes | ❌2 |
Footnotes
-
once the issue noted is worked-around, tab completion works as expected ↩
-
see https://github.com/Chatterino/chatterino2/pull/4855#issuecomment-1741960689 ↩
pajlada
approved these changes
Oct 1, 2023
Felanbird
added a commit
to Felanbird/chatterino2
that referenced
this pull request
Oct 9, 2023
This reverts commit 4bb196c.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes usernames not being tab-completed without the
@prefix (and the "Only search for username autocompletion with an @" setting disabled).The completion items being returned by the user source always started with an
@. The candidate for completion of the queryicelwould be@icelys,which is incompatible due to the extra "@".Fixes #4850