Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nightly to 2.4.6 and get qt6-related-changes from 2.4.6 #4856

Merged

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Oct 1, 2023

Description

This cherry-picks changes from v2.4.6 (the security release), making sure nightly build users also get the same security fixes.
This means nightly will also be for windows 10 and above users now - we'll continue distributing an older build but it is unsafe.

@pajlada pajlada added the skip-changelog-checker Skip the "Changelog Category Check" workflow label Oct 1, 2023
@pajlada pajlada added skip-changelog-checker Skip the "Changelog Category Check" workflow accessibility Features/changes that impact how accessible Chatterino is and removed skip-changelog-checker Skip the "Changelog Category Check" workflow accessibility Features/changes that impact how accessible Chatterino is labels Oct 1, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@@ -24,7 +24,7 @@
* - 2.4.0-alpha.2
* - 2.4.0-alpha
**/
#define CHATTERINO_VERSION "2.4.5"
#define CHATTERINO_VERSION "2.4.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro 'CHATTERINO_VERSION' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]

#define CHATTERINO_VERSION "2.4.6"
        ^

@pajlada
Copy link
Member Author

pajlada commented Oct 1, 2023

image

@pajlada pajlada merged commit 467e367 into master Oct 1, 2023
22 of 27 checks passed
@pajlada pajlada deleted the chore/change-to-qt6-for-windows-and-get-2.4.6-changes branch October 1, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-checker Skip the "Changelog Category Check" workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant