Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Toast #4899

Merged
merged 8 commits into from
Oct 17, 2023
Merged

refactor: Toast #4899

merged 8 commits into from
Oct 17, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Oct 14, 2023

Description

  • Fixes a bug where avatars weren't loaded on fresh installations of Chatterino.
  • Avatars now update every two weeks.
  • Removes misleading DownlaodManager (now part of Toasts.cpp).
  • Refactors usage of WinToast to be easier to read.
  • Added version to AUMI.
  • Removes manual QString → std::wstring conversions.
  • Removes uses of implicit ASCII casts in Toasts.cpp, meaning it can be compiled with QT_NO_CAST_FROM_ASCII.

github-actions[bot]
github-actions bot reviewed Oct 14, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/singletons/Toasts.cpp Show resolved Hide resolved
src/singletons/Toasts.cpp Show resolved Hide resolved
src/singletons/Toasts.cpp Show resolved Hide resolved
pajlada
pajlada requested changes Oct 14, 2023
View reviewed changes
src/singletons/Toasts.cpp Outdated Show resolved Hide resolved
src/singletons/Toasts.cpp Show resolved Hide resolved
src/singletons/Paths.cpp Outdated Show resolved Hide resolved
src/singletons/Toasts.cpp Outdated Show resolved Hide resolved
src/singletons/Toasts.cpp Show resolved Hide resolved
@pajlada pajlada changed the title Refactor toasts refactor: Toast Oct 17, 2023
@pajlada pajlada enabled auto-merge (squash) October 17, 2023 01:26
@pajlada pajlada merged commit b975900 into Chatterino:master Oct 17, 2023
15 checks passed
@Nerixyz Nerixyz mentioned this pull request Oct 22, 2023
Closed
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nerixyz @pajlada