Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selection tests #4904

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Add selection tests #4904

merged 6 commits into from
Oct 23, 2023

Conversation

kornes
Copy link
Contributor

@kornes kornes commented Oct 19, 2023

Adds 100% cover for Selection.hpp

Nerixyz
Nerixyz reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Nerixyz Nerixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few tests now, maybe some directories should be added to group tests?

tests/src/Selection.cpp Outdated Show resolved Hide resolved
tests/src/Selection.cpp Outdated Show resolved Hide resolved
@pajlada pajlada enabled auto-merge (squash) October 23, 2023 20:15
@pajlada pajlada disabled auto-merge October 23, 2023 20:15
@pajlada pajlada enabled auto-merge (squash) October 23, 2023 20:15
@pajlada pajlada merged commit da31e47 into Chatterino:master Oct 23, 2023
15 checks passed
@kornes kornes deleted the tests/selection branch October 23, 2023 20:45
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nerixyz Nerixyz Nerixyz left review comments

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
no changelog entry needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kornes @pajlada @Nerixyz @Felanbird