feat: Add crash recovery on Windows #5012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
feat/win-restart
branch
from
13a71e1 to
ff6804f
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Nerixyz
force-pushed
the
feat/win-restart
branch
from
ff6804f to
47b6dc2
Compare
Nerixyz
force-pushed
the
feat/win-restart
branch
3 times, most recently
from
8426335 to
453daf5
Compare
Nerixyz
force-pushed
the
feat/win-restart
branch
from
453daf5 to
35f2367
Compare
pajlada
requested changes
Dec 16, 2023
CMakeLists.txt
Outdated
| @@ -244,4 +244,6 @@ if (BUILD_BENCHMARKS) | |||
| add_subdirectory(benchmarks) | |||
| endif () | |||
|
|
|||
| add_subdirectory(auxiliary) | |||
There was a problem hiding this comment.
I'm not sure we need the auxiliary subdir, could crash-handler just not live in the repo root dir?
There was a problem hiding this comment.
The reason I chose a subdirectory is that I expect other tools to live here in the future and for those to not pollute the top level directory. For example, if plugins get some CLI or there's some qt plugin, this could live there.
There was a problem hiding this comment.
As we discussed, the crashpad project should be a submodule, and it will live under tools. Neither of these things need to be actioned until this has been approved
pajlada
reviewed
Dec 17, 2023
pajlada
reviewed
Dec 17, 2023
pajlada
reviewed
Dec 17, 2023
pajlada
reviewed
Dec 23, 2023
pajlada
reviewed
Dec 23, 2023
pajlada
reviewed
Dec 23, 2023
pajlada
reviewed
Dec 23, 2023
pajlada
reviewed
Dec 23, 2023
pajlada
reviewed
Dec 23, 2023
pajlada
reviewed
Dec 23, 2023
pajlada
reviewed
Dec 23, 2023
pajlada
reviewed
Dec 23, 2023
pajlada
reviewed
Dec 23, 2023
pajlada
reviewed
Dec 23, 2023
pajlada
reviewed
Dec 24, 2023
pajlada
reviewed
Dec 24, 2023
pajlada
approved these changes
Dec 24, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds effectively re-enables the possibility for Chatterino to restart after a crash on Windows, which was removed in #4351. To restart, we build a custom crash handler that captures some info about the crash and restarts the app (with its arguments) after Crashpad is done processing the crash. Crash recovery is only enabled in release mode. Because crash recovery and set-up of Crashpad happens before the settings are initialized, settings for crash recovery are saved in a separate file (
<crashdump-dir>/chatterino-recovery.bin).I put the handler into a new directory called
auxiliaryas I couldn't find/come up with anything better. The handler is only enabled on Windows.The dialog that shows after a crash happened now contains more information about the crash (exception and where it was saved).
As for the change in
.clang-tidy:cppcoreguidelines-avoid-c-arraysis already enabled and does the same.