Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Replace custom import() with normal Lua require(). #5014

Merged
merged 7 commits into from
Dec 16, 2023

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Dec 11, 2023

Description

This makes our usage of Lua more compatible with existing knowledge and tooling.
Yes this WILL break existing plugins

@Mm2PL Mm2PL changed the title Use require() instead of a custom import() BREAKING: Replace custom import() with normal Lua require(). Dec 11, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/controllers/plugins/LuaAPI.cpp Show resolved Hide resolved
src/controllers/plugins/PluginController.cpp Show resolved Hide resolved
@pajlada pajlada enabled auto-merge (squash) December 16, 2023 11:52
@pajlada pajlada merged commit 5f8c4c6 into master Dec 16, 2023
18 of 20 checks passed
@pajlada pajlada deleted the feature/use_require branch December 16, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants