Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add system theme on Qt 6.5 and up #5118

Merged
merged 6 commits into from
Jan 27, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Jan 21, 2024

As explained in #2452 (comment), Qt 6.5 added a signal for the system color scheme. The system theme I added is a dummy theme that resolves to the correct theme once update is called.

NVIDIA_Share_2024-01-21_11-55-24.mp4

Closes #2452.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/singletons/Theme.cpp Outdated Show resolved Hide resolved
src/singletons/Theme.cpp Outdated Show resolved Hide resolved
@pajlada
Copy link
Member

pajlada commented Jan 21, 2024

I would like to see this use a few more settings in the backend to control

  1. a boolean or enum option to choose to follow the system theme
  2. a setting option (just like the theme selector now) where you can choose which theme to use when your system is using light mode
  3. a setting option (just like the theme selector now) where you can choose which theme to use when your system is using dark mode

The UX might be a bit tricky to get right, so let's keep it simple in this first iteration & just add the checkbox/selector straight up to the settings page.

@pajlada pajlada enabled auto-merge (squash) January 27, 2024 10:27
@pajlada pajlada merged commit c32ee8e into Chatterino:master Jan 27, 2024
19 of 20 checks passed
devJimmyboy pushed a commit to devJimmyboy/chatterino7 that referenced this pull request Feb 11, 2024
* feat: add system theme on Qt 6.5

* chroe: add changelog entry

* refactor: add separate settings

* fix: qt 5

* Update changelog entry

---------

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to respect windows internal light and dark mode and switch accordingly
2 participants