Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more MSVC warnings #5137

Merged
merged 11 commits into from
Jan 30, 2024
Merged

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Jan 29, 2024

Further working towards #4825.

Despite some rather simple fixes, the following was done:

  • Defined _WIN32_WINNT to Windows 10 - this is what the inclusion of Windows.h defines. I'm not 100% sure if this is okay (e.g. looking at support for Window 7 and Windows 8 #4852)
  • Re-enabled C4505 ('function': unreferenced local function has been removed), as we only need to declare static declarations (i.e. declarations for functions local to a translation unit) in headers as either inline or in a source file.
  • Disabled C4458 (declaration of 'identifier' hides class member) as we have a rule of exclusively using this-> to access members.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small note on the passthrough thing, which is a good catch, otherwise looks good 👍

src/providers/twitch/api/Helix.cpp Outdated Show resolved Hide resolved
@pajlada pajlada merged commit 954e198 into Chatterino:master Jan 30, 2024
20 checks passed
@Nerixyz Nerixyz deleted the fix/windows-warnings branch January 30, 2024 17:49
devJimmyboy pushed a commit to devJimmyboy/chatterino7 that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants