Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release plugins alpha #5288

Merged
merged 8 commits into from
May 6, 2024
Merged

Release plugins alpha #5288

merged 8 commits into from
May 6, 2024

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Mar 31, 2024

Adds a scary label and renames plugins from EXPERIMENTAL to alpha and enables them on normal builds. Things to do around merge:

  • Rename the plugins label
  • I'd really like someone to look more carefully at the plugins code. I hope I didn't make any security mistakes in that code. Anyone is more than welcome to submit feedback about this code here.

@Mm2PL Mm2PL added the Feature: EXPERIMENTAL Plugins Stuff related to EXPERIMENTAL Lua plugin support label Mar 31, 2024
@Mm2PL Mm2PL added this to the Post-2.5.0 milestone Mar 31, 2024
@Nerixyz
Copy link
Contributor

Nerixyz commented Mar 31, 2024

Btw, plugins are already enabled on the Ubuntu builds:

- os: ubuntu-20.04
container: ghcr.io/chatterino/chatterino2-build-ubuntu-20.04:latest
qt-version: 6.6.1
force-lto: false
plugins: true
skip-artifact: false
skip-crashpad: false
build-appimage: false
build-deb: true
- os: ubuntu-22.04
container: ghcr.io/chatterino/chatterino2-build-ubuntu-22.04:latest
qt-version: 6.6.1
force-lto: false
plugins: true
skip-artifact: false
skip-crashpad: false
build-appimage: true
build-deb: true

@Mm2PL Mm2PL requested a review from pajlada April 4, 2024 00:38
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave CHATTERINO_PLUGINS off by default in the CMakeLists.txt, but enable it in our CI, move the changelog up (to the new unversioned category after merging), then I'm good to have this merged

@Mm2PL Mm2PL enabled auto-merge (squash) May 6, 2024 14:55
@Mm2PL Mm2PL merged commit 321d881 into master May 6, 2024
17 checks passed
@Mm2PL Mm2PL deleted the chore/plugins-public-alpha-release branch May 6, 2024 15:03
Mm2PL added a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: EXPERIMENTAL Plugins Stuff related to EXPERIMENTAL Lua plugin support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants