Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(luals-meta): generate globals in c2 and echo @lua commands #5385

Merged
merged 6 commits into from
May 22, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented May 7, 2024

Based on changes in #5383, I noticed the enums weren't in the c2 global and nested structs weren't supported. This PR applies the fix from #5383 and moves everything we declare into the c2 global. The rule of thumb is: everything that gets a declaration in the metadata should be prefixed with c2 (→ "interfaces" i.e. classes without functions don't have to be in c2).

@Mm2PL Mm2PL merged commit ec6b1ef into Chatterino:master May 22, 2024
17 checks passed
@Nerixyz Nerixyz deleted the fix/more-luals-fixes branch May 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants