-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to suppress live notifications on startup #5388
feat: add option to suppress live notifications on startup #5388
Conversation
ae9a252
to
6f03b65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
also closes #3411 |
b44dc59
to
c132c62
Compare
c132c62
to
29daaf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
This PR adds an option to suppress the initial live notification (🤓 but the title says "startup"). An initial live notification is a notification resulting from the first encountered live status update in a TwitchChannel and a fake channel (both are independent). A change could be the application starting up, but it's also a channel being joined for the first time or a channel going from TwitchChannel → fake or the other way around. I think having "startup" as the title of the option is clear enough.
Additionally, some inconsistencies have been fixed (e.g. streamer mode not suppressing toasts, toasts from fake channels not having a title, ...). TwitchChannel and fake channels now use the same implementation to send notifications.
Closes #3006.
I'm waiting for #4868, so I'll mark this as a draft.