Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to suppress live notifications on startup #5388

Merged
merged 11 commits into from
Jul 20, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented May 10, 2024

This PR adds an option to suppress the initial live notification (🤓 but the title says "startup"). An initial live notification is a notification resulting from the first encountered live status update in a TwitchChannel and a fake channel (both are independent). A change could be the application starting up, but it's also a channel being joined for the first time or a channel going from TwitchChannel → fake or the other way around. I think having "startup" as the title of the option is clear enough.

Additionally, some inconsistencies have been fixed (e.g. streamer mode not suppressing toasts, toasts from fake channels not having a title, ...). TwitchChannel and fake channels now use the same implementation to send notifications.

Closes #3006.

I'm waiting for #4868, so I'll mark this as a draft.

@Nerixyz Nerixyz force-pushed the feat/suppress-live-on-start branch from ae9a252 to 6f03b65 Compare May 10, 2024 20:58
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/util/QCompareCaseInsensitive.hpp Show resolved Hide resolved
src/util/QCompareCaseInsensitive.hpp Outdated Show resolved Hide resolved
src/util/QCompareCaseInsensitive.hpp Outdated Show resolved Hide resolved
src/util/QCompareCaseInsensitive.hpp Show resolved Hide resolved
src/util/QCompareCaseInsensitive.hpp Outdated Show resolved Hide resolved
src/util/QCompareCaseInsensitive.hpp Outdated Show resolved Hide resolved
src/util/QCompareCaseInsensitive.hpp Outdated Show resolved Hide resolved
src/util/QCompareCaseInsensitive.hpp Outdated Show resolved Hide resolved
src/util/QCompareCaseInsensitive.hpp Outdated Show resolved Hide resolved
src/util/QCompareCaseInsensitive.hpp Outdated Show resolved Hide resolved
@killertofus
Copy link
Contributor

also closes #3411

@Nerixyz Nerixyz force-pushed the feat/suppress-live-on-start branch 2 times, most recently from b44dc59 to c132c62 Compare May 14, 2024 19:12
@Nerixyz Nerixyz force-pushed the feat/suppress-live-on-start branch from c132c62 to 29daaf2 Compare May 14, 2024 19:14
@Nerixyz Nerixyz marked this pull request as ready for review May 14, 2024 19:30
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@pajlada pajlada enabled auto-merge (squash) July 20, 2024 12:04
@pajlada pajlada merged commit 0495fbc into Chatterino:master Jul 20, 2024
17 checks passed
@Nerixyz Nerixyz deleted the feat/suppress-live-on-start branch July 20, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - Suppress Windows desktop notifications on startup
3 participants