fix: don't use DPI aware functions on Qt 5 (Windows 7/8) #5391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4868 added DPI aware functions that only work on Windows 10. When compiling with Qt 5 on Windows, it is now assumed the application will run on older systems. Maybe there should be a warning when running with Qt 5 on Windows 10 to use Qt 6.
Fixes #5390.
To make this work on Qt 5 and Windows 10, I'd need to load
user32.dlland find the export (if it's there). I don't think that's worth the effort.