Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usercard jumping when loading data #5406

Merged
merged 2 commits into from
May 19, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented May 19, 2024

As anticipated in #5404, there are places expecting scaleChangedEvent to be called more often. One such place is Label which is used in UserInfoPopup. Before, it would jump when follower and subscription data was loaded. This PR fixes that bug. Thank you to @brian6932 for reporting this.

Copy link
Contributor

@brian6932 brian6932 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fixed to me.

@pajlada pajlada enabled auto-merge (squash) May 19, 2024 19:55
@pajlada pajlada merged commit 8ba5704 into Chatterino:master May 19, 2024
17 checks passed
@Nerixyz Nerixyz deleted the fix/usercard-jumpy branch May 19, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants