fix: use irc-unknown when irc server couldn't be loaded
#5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I think if a server doesn't exist we shouldn't even attempt to log these messages. The core issue is that this:
can happen and we still receive and handle a message. |
|
If we stop the message I noticed getting through from coming through, then we fix that crash. All it would take is another message coming through to cause another crash - regardless of what we do, this should still be the preferred behaviour over crashing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If logging is enabled and you have joined an IRC server/channel before that's now been removed somehow (by irc server being removed or irc support being disabled), the channel logger will now log the channel contents to
irc-unknowninstead of erroring out