Fix: tabs move animation for duplicated tabs #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
approved these changes
Jun 1, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -407,30 +408,32 @@ void NotebookTab::hideTabXChanged() | |||
| this->update(); | |||
| } | |||
|
|
|||
| void NotebookTab::moveAnimated(QPoint pos, bool animated) | |||
| void NotebookTab::moveAnimated(QPoint targetPos, bool animated) | |||
There was a problem hiding this comment.
warning: no header providing "QPoint" is directly included [misc-include-cleaner]
src/widgets/helper/NotebookTab.cpp:26:
+ #include <qpoint.h>| return; | ||
| } | ||
|
|
||
| if (this->positionChangedAnimation_.endValue() == pos) | ||
| if (this->positionChangedAnimation_.state() == | ||
| QAbstractAnimation::Running && |
There was a problem hiding this comment.
warning: no header providing "QAbstractAnimation" is directly included [misc-include-cleaner]
src/widgets/helper/NotebookTab.cpp:26:
+ #include <qabstractanimation.h>| @@ -65,7 +65,7 @@ class NotebookTab : public Button | |||
| void setHighlightsEnabled(const bool &newVal); | |||
| bool hasHighlightsEnabled() const; | |||
|
|
|||
| void moveAnimated(QPoint pos, bool animated = true); | |||
| void moveAnimated(QPoint targetPos, bool animated = true); | |||
There was a problem hiding this comment.
warning: no header providing "QPoint" is directly included [misc-include-cleaner]
src/widgets/helper/NotebookTab.hpp:10:
+ #include <qpoint.h>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro steps
Issue
positionChangedAnimation_(QAbstractAnimation) for tabs is kept between animations,if
endValue()of previously run animation match current targetPos - animation won't fire even though it should because current starting position might be different. This results in a gap which will stay until next notebook layout happen (where all tabs are moved again without animation).There are also a lot of unnecessary Notebook layouts (like creating new tab results in 5x layouts of whole notebook) so that's something to fix too.
Fix
endValuefor animation is now only checked for running animations (adf0458)added some minor refactors too