fix: handle older VC redist versions #5447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Nerixyz
force-pushed
the
fix/handle-old-vc-redist
branch
from
5671128 to
423837f
Compare
pajlada
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Visual Studio v17.10 and MSVC 14.40, we require a new VC Runtime to be installed (see https://github.com/microsoft/STL/releases/tag/vs-2022-17.10). Alternatively, we can set
_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR. I hate to do that, but it's the best option for users (it's not yet on, but I'll probably enable it). By default, builds will build without it (these builds will show a warning when started). Ideally, we'd statically link to it, but I'm not sure if that's possible (#2323).