Enable antialiasing for reply button #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jupjohn
approved these changes
Jul 5, 2024
Nerixyz
reviewed
Jul 5, 2024
| @@ -392,6 +392,7 @@ void ImageWithCircleBackgroundLayoutElement::paint( | |||
| if (pixmap && !this->image_->animated()) | |||
| { | |||
| QRectF boxRect(this->getRect()); | |||
| painter.setRenderHint(QPainter::Antialiasing); | |||
There was a problem hiding this comment.
This should be changed to the value it had before, after calling drawPixmap (probably best to read it before calling setRenderHint rather than pushing the state).
There was a problem hiding this comment.
I went ahead and added QPainter::save and QPainter::restore calls around every message layout element paint in a4daddf
Nerixyz
approved these changes
Jul 5, 2024
|
Save/restore also affects all writes to pen, brush, etc so I added it outside since it seemed like we wanted to isolate the effects to the painter from inside each message element. But we could instead have it only wherever we use render hints, which is perhaps where it really matters. |
pajlada
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables antialiasing for the reply button. This has always bugged me. I saw a screenshot of Chatterino on Twitter and was instantly compelled to fix it. Before/after: