Add extra context to messages that are added to channels, allowing the logging controller to take more responsibility in what messages to log #5499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used by the logger to check if it should be logged or not
pajlada
force-pushed
the
fix/prevent-bad-logging
branch
from
a55a6e4 to
684e93e
Compare
pajlada
changed the title
pajlada
changed the title
Confirm that inline whispers are reposts
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -28,6 +28,14 @@ enum class TimeoutStackStyle : int { | |||
| Default = DontStackBeyondUserMessage, | |||
| }; | |||
|
|
|||
| /// Context of the message being added to a channel | |||
| enum class MessageContext { | |||
There was a problem hiding this comment.
warning: enum 'MessageContext' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]
enum class MessageContext {
^|
|
||
| if (getSettings()->inlineWhispers && | ||
| !(getSettings()->streamerModeSuppressInlineWhispers && | ||
| getIApp()->getStreamerMode()->isEnabled())) | ||
| { | ||
| app->getTwitchAbstract()->forEachChannel( | ||
| [&messagexD, overrideFlags](ChannelPtr _channel) { | ||
| _channel->addMessage(messagexD, overrideFlags); | ||
| [&messagexD](ChannelPtr _channel) { |
There was a problem hiding this comment.
warning: the parameter '_channel' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Suggested change
| [&messagexD](ChannelPtr _channel) { | |
| [&messagexD](const ChannelPtr& _channel) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed the
DoNotLogflags fromUserInfoPopupon purpose since all messages added from it are "reposts", i.e. messages that wouldn't be logged anywayCurrently it's the logger that checks whether or not to log reposts - this should just be moved to Channel's addMessage function insteadFixes #5470